Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a config argument to hysr_visualization #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jan1854
Copy link
Member

@jan1854 jan1854 commented Sep 26, 2024

Description

This adds the option to pass a config file as input to hysr_visualization, which is needed if there are multiple json files in the current directory (e.g., different configs for training and evaluation).

How I Tested

Ran hysr_visualization and hysr_visualization config.json.

I fulfilled the following requirements

  • All new code is formatted according to our style guide (for C++ run clang-format, for Python, run flake8 and fix all warnings).
  • All new functions/classes are documented and existing documentation is updated according to changes.
  • No commented code from testing/debugging is kept (unless there is a good reason to keep it).

@jan1854 jan1854 assigned jan1854 and vincentberenz and unassigned jan1854 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants