Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support media channels #1458

Merged
merged 4 commits into from
Jul 7, 2023
Merged

feat: support media channels #1458

merged 4 commits into from
Jul 7, 2023

Conversation

LordOfPolls
Copy link
Contributor

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

Adds support for media channels - effectively just fancy forum channels

Please note, media channels are in beta - this pr may need to be updated

Changes

  • Implement a class for media channels
  • Add a mapping for media channels

Related Issues

discord/discord-api-docs#6232

Test Scenarios

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (5a29624) 60.29% compared to head (150e6ae) 60.19%.

❗ Current head 150e6ae differs from pull request most recent head ae77515. Consider uploading reports for the commit ae77515 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1458      +/-   ##
============================================
- Coverage     60.29%   60.19%   -0.10%     
============================================
  Files           139      139              
  Lines         14731    14738       +7     
============================================
- Hits           8882     8872      -10     
- Misses         5849     5866      +17     
Impacted Files Coverage Δ
interactions/__init__.py 88.88% <ø> (ø)
interactions/models/__init__.py 100.00% <ø> (ø)
interactions/models/discord/__init__.py 100.00% <ø> (ø)
interactions/models/discord/channel.py 52.14% <100.00%> (+0.19%) ⬆️
interactions/models/discord/enums.py 96.62% <100.00%> (+0.01%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@i0bs i0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General statements, not necessarily a full review

@AstreaTSS AstreaTSS mentioned this pull request Jul 4, 2023
4 tasks
LordOfPolls and others added 2 commits July 5, 2023 06:15
Co-authored-by:  i0bs <41456914+i0bs@users.noreply.github.com>
@LordOfPolls LordOfPolls marked this pull request as ready for review July 5, 2023 05:17
@LordOfPolls LordOfPolls mentioned this pull request Jul 5, 2023
13 tasks
@LordOfPolls LordOfPolls merged commit 21f51b4 into unstable Jul 7, 2023
11 checks passed
@LordOfPolls LordOfPolls deleted the media_channel branch July 7, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants