fix: allow delete_after for ephemeral messages #1467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This PR allows using
delete_after
for ephemeral messages, which previously produced an error due to not passing the context in formessage.delete(...)
. This uses a purposely hidden kwarg to do so - let me know if that needs to be changed.Changes
SendMixin
to determine if the mixin should pass in itself formessage.delete(...)
. I figured it was better than using an isinstance and potentially maybe causing recursive imports.InteractionContext
andHybridContext
pass this value as appropriate.Related Issues
Fixes #1465.
Test Scenarios
delete_after
while sending.Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files