Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow editing for guild role icons #1558

Merged
merged 13 commits into from
Oct 5, 2023
Merged

feat: allow editing for guild role icons #1558

merged 13 commits into from
Oct 5, 2023

Commits on Aug 8, 2023

  1. Merge pull request interactions-py#1524 from interactions-py/unstable 

    5.9.2
    @silasary
    silasary authored Aug 8, 2023
    Configuration menu
    Copy the full SHA
    125ead2 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2023

  1. Merge pull request interactions-py#1545 from interactions-py/unstable 

    5.10.0
    @LordOfPolls
    LordOfPolls authored Sep 10, 2023
    Configuration menu
    Copy the full SHA
    2845b4f View commit details
    Browse the repository at this point in the history

  2. chore: Version bump 

    Signed-off-by: LordOfPolls <dev@lordofpolls.com>
    @LordOfPolls
    LordOfPolls authored Sep 10, 2023
    Configuration menu
    Copy the full SHA
    0129d53 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Implemented role icon edit

    @example-git
    example-git committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    24d81d8 View commit details
    Browse the repository at this point in the history

  2. added role icon editing to the edit method

    @example-git
    example-git committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    8656319 View commit details
    Browse the repository at this point in the history

  3. Update misc_utils.py

    @example-git
    example-git committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    b3b9a67 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'unstable' into role-icon-editing

    @example-git
    example-git committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    1873644 View commit details
    Browse the repository at this point in the history

  5. ci: correct from checks.

    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    cdc6f9b View commit details
    Browse the repository at this point in the history

  6. fixed formatting, added return formatting indicator

    @example-git
    example-git committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    3b1e7a9 View commit details
    Browse the repository at this point in the history

  7. Update role.py

    @example-git
    example-git committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    30024f6 View commit details
    Browse the repository at this point in the history

  8. Noticed that interactions.client.utils.serializer 

    already had the functions I added to misc_utils. Undid those changes and tidied up the code in role.py to reflect the already existing converter.  Added an error raise if both icon and unicode emojis are used in one edit (the api requires only one is provided.)
    @example-git
    example-git committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    7cd9e10 View commit details
    Browse the repository at this point in the history

  9. Cleaned up the docstring and moved the icon serialization 

    cleaned up the docstring to better align with requirements, moved the icon serialization so the payload's code is a bit easier to follow at a glance.
    @example-git
    example-git committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    d7aad9e View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Added UPLOADABLE_TYPE per comment

    @example-git
    example-git committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    ccf9e09 View commit details
    Browse the repository at this point in the history