Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add safety alerts channel to guild model #1588

Closed
wants to merge 3 commits into from

Conversation

ItsRqtl
Copy link
Contributor

@ItsRqtl ItsRqtl commented Dec 4, 2023

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

This PR adds safety alerts channel related stuff to the Guild model.

Changes

  • added safety_alerts_channel_id field
  • added safety_alerts_channel property
  • added safety_alerts_channel args to Guild.edit method
  • added safety_alerts_channel_id args to http.modify_guild method

Related Issues

Test Scenarios

Get a guild that has a safety alerts channel set, check the safety_alerts_channel is equal to the one being set
Edit the guild with the Guild.edit method, check if Guild.safety_alerts_channel == the one being passed into Guild.edit

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@ItsRqtl ItsRqtl changed the base branch from stable to unstable December 4, 2023 20:12
@ItsRqtl ItsRqtl closed this Dec 4, 2023
@ItsRqtl ItsRqtl deleted the guild-safety-alert branch December 4, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant