Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow removing files and embeds by editing #1697

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

ItsRqtl
Copy link
Contributor

@ItsRqtl ItsRqtl commented Jun 8, 2024

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

Allow users to remove files or embeds from messages by passing an empty list into files/embeds fields in edit method of Message/InteractionContext or edit_origin method of ComponentContext.

Changes

Related Issues

Not on GitHub but the related Discord thread:
https://discord.com/channels/789032594456576001/1245924804314267760

Test Scenarios

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@silasary silasary merged commit d65e2a0 into interactions-py:unstable Jun 20, 2024
2 checks passed
@ItsRqtl ItsRqtl deleted the edit-fix branch June 20, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants