Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to add Wikidata IDs to works #1797

Closed
Tracked by #8271
GerardMeijssen opened this issue Jan 1, 2019 · 9 comments · May be fixed by #8346
Closed
Tracked by #8271

Option to add Wikidata IDs to works #1797

GerardMeijssen opened this issue Jan 1, 2019 · 9 comments · May be fixed by #8346
Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Module: Wikidata Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Identifiers Issues related to ISBN's or other identifiers in metadata. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@GerardMeijssen
Copy link

GerardMeijssen commented Jan 1, 2019 •
edited by cdrini
Loading

In the same way that you can add Wikidata IDs to editions or to authors, there should be a way to add them to works. Wikidata has a notion of Works as well.

e.g. https://www.wikidata.org/wiki/Q43361
@mekarpeles mekarpeles changed the title For books (works) you could allow for the inclusion of Wikidata items like we do for authors. For books (works) allow linking to Wikidata IDs (a la authors) Jan 2, 2019
@LeadSongDog
Copy link

The reverse is also possible: wikidata items for a book may have an OLID parameter P648 identified. For example Q1639633 "Vingt ans après" has P648 with value "OL36858W"

@xayhewalo
Copy link
Collaborator

Wikidata is in the identifier dropdown for editions now. Closing.

@cdrini
Copy link
Collaborator

cdrini commented Nov 12, 2019

This is a separate issue; it asks to have wikidata links on the work.

Related: #856

@cdrini cdrini reopened this Nov 12, 2019
@cdrini cdrini changed the title For books (works) allow linking to Wikidata IDs (a la authors) Option to add Wikidata IDs to works Nov 12, 2019
@cdrini cdrini added the Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] label Nov 12, 2019
@xayhewalo xayhewalo added State: Backlogged Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Identifiers Issues related to ISBN's or other identifiers in metadata. [managed] labels Nov 12, 2019
@xayhewalo
Copy link
Collaborator

Noted.

Assigning @hornc per slack discussions. Seems like this would require a schema change.

@mekarpeles mekarpeles added the Lead: @hornc Issues overseen by Charles (Staff: Data Engineering Lead) [managed] label Dec 18, 2019
@hornc hornc removed their assignment Jan 14, 2020
This was referenced Apr 11, 2021
Open
Open
@tfmorris
Copy link
Contributor

#3430 is a superset of this

@hornc hornc removed the Lead: @hornc Issues overseen by Charles (Staff: Data Engineering Lead) [managed] label Sep 10, 2023
@mekarpeles mekarpeles added Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] and removed Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] labels Sep 15, 2023
@mekarpeles mekarpeles mentioned this issue Sep 16, 2023
Open
9 tasks
davidscotson added a commit to davidscotson/openlibrary that referenced this issue Oct 1, 2023
@davidscotson
feature add ids to works
18a048f 
fixes internetarchive#3430 and internetarchive#1797

Not fully ready to merge, for at least two reasons:

Displays the ids on the work/edition page though internetarchive#3430 currently
suggests this is optional, so may need removed until a design is
settled.

One currently unsolved issue, if you add an id to the work, and
it's the same as the edition, you get an error. I think this might
actually be desired behaviour, I just don't actually understand
how the code is picking this up.
@davidscotson davidscotson mentioned this issue Oct 1, 2023
Draft
davidscotson added a commit to davidscotson/openlibrary that referenced this issue Oct 2, 2023
@davidscotson
feature add ids to works
346f8dc 
fixes internetarchive#3430 and internetarchive#1797

Not fully ready to merge, for at least two reasons:

Displays the ids on the work/edition page though internetarchive#3430 currently
suggests this is optional, so may need removed until a design is
settled.
@RayBB
Copy link
Collaborator

RayBB commented Oct 6, 2023

Closing this as it will be addressed as part of #3430 (which currently has a nice PR opened by @davidscotson)

@RayBB RayBB closed this as completed Oct 6, 2023
@hornc hornc reopened this Oct 9, 2023
@hornc
Copy link
Collaborator

hornc commented Oct 9, 2023

When the PR is merged the issue will automatically get closed. It shouldn't be closed early in case the currently Draft PR changes, or does not get merged.

davidscotson added a commit to davidscotson/openlibrary that referenced this issue Oct 9, 2023
@davidscotson
feature add ids to works
005d798 
fixes internetarchive#3430 and internetarchive#1797

Not fully ready to merge, for at least two reasons:

Displays the ids on the work/edition page though internetarchive#3430 currently
suggests this is optional, so may need removed until a design is
settled.
davidscotson added a commit to davidscotson/openlibrary that referenced this issue Oct 9, 2023
@davidscotson
feature add ids to works
7d533c5 
fixes internetarchive#3430 and internetarchive#1797

Not fully ready to merge, for at least two reasons:

Displays the ids on the work/edition page though internetarchive#3430 currently
suggests this is optional, so may need removed until a design is
settled.
davidscotson added a commit to davidscotson/openlibrary that referenced this issue Oct 9, 2023
@davidscotson
feature add ids to works
68dc489 
fixes internetarchive#3430 and internetarchive#1797

Not fully ready to merge, for at least two reasons:

Displays the ids on the work/edition page though internetarchive#3430 currently
suggests this is optional, so may need removed until a design is
settled.
davidscotson added a commit to davidscotson/openlibrary that referenced this issue Oct 9, 2023
@davidscotson
feature add ids to works
d9b4059 
fixes internetarchive#3430 and internetarchive#1797

Adds the option to add external ids (wikidata, VIAF) to works, based
on the code for editions, with minor tweaks.
@tfmorris
Copy link
Contributor

tfmorris commented Oct 9, 2023

@hornc I think since this issue is a subset of issue #3430, it's OK to close this and use that issue to track the status of the PR.

davidscotson added a commit to davidscotson/openlibrary that referenced this issue Nov 9, 2023
@davidscotson
feature add ids to works
ce23536 
fixes internetarchive#3430 and internetarchive#1797

Adds the option to add external ids (wikidata, VIAF) to works, based
on the code for editions, with minor tweaks.

Will autodetect the id type when possible, similar to functionality
in the author id entry.

Will accept urls for ids and automatically extract the id from them
based on regex sourced from wikidata.
@cdrini
Copy link
Collaborator

cdrini commented Jun 17, 2024

I'm cleaning up/finishing a few issues related to adding identifiers. I added wikidata to the https://openlibrary.org/config/work file, which, once #3430 is completed, will allow Wikidata to automatically be added via the UI. That is the issue to track for this; closing since there's no more work to be done on this one!

@cdrini cdrini closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Module: Wikidata Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Identifiers Issues related to ISBN's or other identifiers in metadata. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature add ids to works davidscotson/openlibrary
8 participants
@tfmorris @hornc @RayBB @mekarpeles @cdrini @xayhewalo @LeadSongDog @GerardMeijssen