Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: integrate main to develop/pwa #745

Merged
merged 7 commits into from
Jul 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/icm-replication/.bumpversion.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tool.bumpversion]
current_version = "2.1.5"
current_version = "2.2.0"

[[tool.bumpversion.files]]
filename = "Chart.yaml"
Expand Down
6 changes: 3 additions & 3 deletions charts/icm-replication/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,16 @@ appVersion: "11.9.0"
description: Intershop Commerce Management - ICM Replication
# name and version must be in this exact order, otherwise bump2version won't work
name: icm-replication
version: 2.1.5
version: 2.2.0
annotations:
requestedMemoryQuota: 9Gi
requestedCpuQuotaInMinutes: 3000
dependencies:
- name: icm
version: 2.1.3
version: 2.2.0
repository: file://../icm
alias: icm-live
- name: icm
version: 2.1.3
version: 2.2.0
repository: file://../icm
alias: icm-edit
2 changes: 1 addition & 1 deletion charts/icm-web/.bumpversion.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tool.bumpversion]
current_version = "0.9.1"
current_version = "0.10.0"

[[tool.bumpversion.files]]
filename = "Chart.yaml"
Expand Down
15 changes: 15 additions & 0 deletions charts/icm-web/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,26 @@

<a name="icm-web-0.10.0"></a>
## [icm-web-0.10.0](https://github.com/intershop/helm-charts/compare/icm-web-0.9.1...icm-web-0.10.0)

> 2024-07-09

### Chore

* bump versions of icm-web:minor

### Feat

* **icm:** Try to schedule WA pods evenly over different nodes ([#729](https://github.com/intershop/helm-charts/issues/729))


<a name="icm-web-0.9.1"></a>
## [icm-web-0.9.1](https://github.com/intershop/helm-charts/compare/icm-web-0.9.0...icm-web-0.9.1)

> 2024-06-10

### Chore

* generated changelog+release notes for icm:patch icm-as:patch icm-replication:patch icm-web:patch
* bump versions of icm:patch icm-as:patch icm-replication:patch icm-web:patch
* Consume WebAdapterAgent 4.0.1
* Consume WebAdapter 2.5.0
Expand Down
2 changes: 1 addition & 1 deletion charts/icm-web/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ appVersion: "11.0.13"
description: Intershop Commerce Management - Web Adapter and Web Adapter Agent
# name and version must be in this exact order, otherwise bump2version won't work
name: icm-web
version: 0.9.1
version: 0.10.0
15 changes: 6 additions & 9 deletions charts/icm-web/RELEASE_NOTES.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,14 @@

<a name="icm-web-0.9.1"></a>
## [icm-web-0.9.1](https://github.com/intershop/helm-charts/compare/icm-web-0.9.0...icm-web-0.9.1)
<a name="icm-web-0.10.0"></a>
## [icm-web-0.10.0](https://github.com/intershop/helm-charts/compare/icm-web-0.9.1...icm-web-0.10.0)

> 2024-06-10
> 2024-07-09

### Chore

* bump versions of icm:patch icm-as:patch icm-replication:patch icm-web:patch
* Consume WebAdapterAgent 4.0.1
* Consume WebAdapter 2.5.0
* bump versions of icm-web:minor

### Fix
### Feat

* Support graceful container shutdown of WebAdapterAgent
* Support graceful container shutdown of WebAdapter
* **icm:** Try to schedule WA pods evenly over different nodes ([#729](https://github.com/intershop/helm-charts/issues/729))

18 changes: 18 additions & 0 deletions charts/icm-web/templates/wa-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,24 @@ spec:
nodeSelector:
{{- toYaml .Values.nodeSelector | trim | nindent 8 }}
{{- end }}
{{- if and (not .Values.nodeSelector) (.Values.webadapter.schedulePodsPreferredEvenlyAcrossNodes) }}
affinity:
podAntiAffinity:
# Choose schedulability over pod anti-affinity preference satisfaction
preferredDuringSchedulingIgnoredDuringExecution:
- weight: 100
podAffinityTerm:
# Spread WA pods evenly over nodes
# See ticket #95582 regarding the simultaneous kill at nearly the exact same moment,
# likely same node was affected by memory pressure
topologyKey: "kubernetes.io/hostname"
labelSelector:
matchExpressions:
- key: app
operator: In
values:
- {{ include "icm-web.fullname" . }}-wa
{{- end }}
{{- if .Values.imagePullSecrets }}
imagePullSecrets:
{{- range .Values.imagePullSecrets }}
Expand Down
3 changes: 3 additions & 0 deletions charts/icm-web/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ webadapter:
enabled: false
binding: <name-of-the-binding>

# define if the scheduler should try to place the ReplicaSet of WA pods evenly over different nodes
schedulePodsPreferredEvenlyAcrossNodes: true

# define custom labels for deployment and pods:
deploymentLabels: {}
podLabels: {}
Expand Down
2 changes: 1 addition & 1 deletion charts/icm/.bumpversion.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tool.bumpversion]
current_version = "2.1.3"
current_version = "2.2.0"

[[tool.bumpversion.files]]
filename = "Chart.yaml"
Expand Down
4 changes: 2 additions & 2 deletions charts/icm/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: "12.0.0"
description: Intershop Commerce Management - ICM
# name and version must be in this exact order, otherwise bump2version won't work
name: icm
version: 2.1.3
version: 2.2.0
# test related annotations
annotations:
requestedMemoryQuota: 5300Mi
Expand All @@ -13,7 +13,7 @@ dependencies:
version: 2.0.2
repository: file://../icm-as
- name: icm-web
version: 0.9.1
version: 0.10.0
repository: file://../icm-web
condition: icm-web.enabled
- name: ingress-nginx
Expand Down