fix(database): call cancellation callback when using ref.on (#5371)

* call cancellation callback when using ref.on * unskip test Co-authored-by: Mike Hardy <github@mikehardy.net>
invertase · Jul 16, 2021 · 26b59db · 26b59db · vercel · Jul 16, 2021
1 parent 3c438a9
commit 26b59db
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/database/e2e/query/on.e2e.js b/packages/database/e2e/query/on.e2e.js
@@ -108,7 +108,7 @@ describe('database().ref().on()', function () {
   });
 
   // the cancelCallback is never called for ref.on but ref.once works?
-  xit('should cancel when something goes wrong', async function () {
+  it('should cancel when something goes wrong', async function () {
     const successCallback = sinon.spy();
     const cancelCallback = sinon.spy();
     const ref = firebase.database().ref('nope');

diff --git a/packages/database/lib/DatabaseSyncTree.js b/packages/database/lib/DatabaseSyncTree.js
@@ -263,7 +263,7 @@ class DatabaseSyncTree {
 
     if (once) {
       const subscription = SharedEventEmitter.addListener(eventRegistrationKey, event => {
-        this._onOnceRemoveRegistration(eventRegistrationKey, listener, event);
+        this._onOnceRemoveRegistration(eventRegistrationKey, listener)(event);
         subscription.remove();
       });
     } else {