Skip to content

Commit

Permalink
feat(app, sdk)!: ios-sdk 10.10.0, requires Xcode 14.1+ / macOS 12.5+
Browse files Browse the repository at this point in the history
BREAKING CHANGE: this version of the underlying firebase-ios-sdk has
a minimum Xcode requirement of 14.1 which transitively implies a macOS
minimum version of 12.5
  • Loading branch information
mikehardy committed Jun 5, 2023
1 parent a0e76ec commit 3122918
Show file tree
Hide file tree
Showing 4 changed files with 395 additions and 364 deletions.
4 changes: 2 additions & 2 deletions docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ If you do not meet these prerequisites, follow the links below:
- [React Native - Setting up the development environment](https://reactnative.dev/docs/environment-setup)
- [Create a new Firebase project](https://console.firebase.google.com/)

Additionally, current versions of firebase-ios-sdk have a minimum Xcode requirement of 13.3, which implies a minimum macOS version of 12 (macOS Monterey).
Additionally, current versions of firebase-ios-sdk have a minimum Xcode requirement of 14.1, which implies a minimum macOS version of 12.5 (macOS Monterey).

## Installation

Expand Down Expand Up @@ -233,7 +233,7 @@ Open your projects `/ios/Podfile` and add any of the globals shown below to the

```ruby
# Override Firebase SDK Version
$FirebaseSDKVersion = '10.8.0'
$FirebaseSDKVersion = '10.10.0'
```

Once changed, reinstall your projects pods via pod install and rebuild your project with `npx react-native run-ios`.
Expand Down
2 changes: 1 addition & 1 deletion packages/app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
},
"sdkVersions": {
"ios": {
"firebase": "10.8.0",
"firebase": "10.10.0",
"iosTarget": "11.0",
"macosTarget": "10.13"
},
Expand Down
7 changes: 2 additions & 5 deletions packages/firestore/e2e/Bundle/namedQuery.e2e.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,8 @@ describe('firestore().namedQuery()', function () {
snapshot.docs[0].metadata.fromCache.should.eql(true);
});

it('returns QuerySnapshot from firestore backend when omitting "source: cache"', async function () {
// TODO: log upstream issue - this broke with BoM >= 32.0.0, source always appears to be cache now
if (device.getPlatform() === 'android') {
this.skip();
}
// TODO: log upstream issue - this broke with BoM >= 32.0.0, source always appears to be cache now
xit('returns QuerySnapshot from firestore backend when omitting "source: cache"', async function () {
const docRef = firebase.firestore().collection(BUNDLE_COLLECTION).doc();
await docRef.set({ number: 4 });

Expand Down
Loading

0 comments on commit 3122918

Please sign in to comment.