Skip to content

Commit

Permalink
feat(analytics, ios): implement firebase.json toggle to override defa…
Browse files Browse the repository at this point in the history
  • Loading branch information
mikehardy committed Jun 22, 2022
1 parent c0b5e5c commit 5da99bd
Show file tree
Hide file tree
Showing 5 changed files with 48 additions and 35 deletions.
4 changes: 4 additions & 0 deletions packages/app/firebase-schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@
"description": "If you wish to disable automatic screen reporting in your app.\n This cannot be altered at runtime once set in the config.",
"type": "boolean"
},
"google_analytics_registration_with_ad_network_enabled": {
"description": "For your convenience, on iOS the SDK automatically registers your app with Apple for ad network attribution with SKAdNetwork.\nDefaults to true, include this key as false to disable.",
"type": "boolean"
},
"analytics_default_allow_ad_personalization_signals": {
"description": "Configure whether a user's Analytics data may be used for personalized advertising in other products.\n If set, may be overridden at runtime by calling setUserProperty on the key 'allow_personalized_ads'",
"type": "boolean"
Expand Down
8 changes: 8 additions & 0 deletions packages/app/ios_config.sh
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,14 @@ if [[ ${_SEARCH_RESULT} ]]; then
_PLIST_ENTRY_VALUES+=("$(jsonBoolToYesNo "$_ANALYTICS_PERSONALIZATION")")
fi

# config.analytics_registration_with_ad_network_enabled
_ANALYTICS_REGISTRATION_WITH_AD_NETWORK=$(getFirebaseJsonKeyValue "$_JSON_OUTPUT_RAW" "google_analytics_registration_with_ad_network_enabled")
if [[ $_ANALYTICS_REGISTRATION_WITH_AD_NETWORK ]]; then
_PLIST_ENTRY_KEYS+=("GOOGLE_ANALYTICS_REGISTRATION_WITH_AD_NETWORK_ENABLED")
_PLIST_ENTRY_TYPES+=("bool")
_PLIST_ENTRY_VALUES+=("$(jsonBoolToYesNo "$_ANALYTICS_REGISTRATION_WITH_AD_NETWORK")")
fi

# config.google_analytics_automatic_screen_reporting_enabled
_ANALYTICS_AUTO_SCREEN_REPORTING=$(getFirebaseJsonKeyValue "$_JSON_OUTPUT_RAW" "google_analytics_automatic_screen_reporting_enabled")
if [[ $_ANALYTICS_AUTO_SCREEN_REPORTING ]]; then
Expand Down
1 change: 1 addition & 0 deletions tests/firebase.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"google_analytics_adid_collection_enabled": true,
"google_analytics_ssaid_collection_enabled": true,
"google_analytics_automatic_screen_reporting_enabled": true,
"google_analytics_registration_with_ad_network_enabled": true,
"analytics_default_allow_ad_personalization_signals": true,

"perf_auto_collection_enabled": false,
Expand Down
68 changes: 34 additions & 34 deletions tests/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1167,70 +1167,70 @@ PODS:
- React-jsi (= 0.67.3)
- React-logger (= 0.67.3)
- React-perflogger (= 0.67.3)
- RNFBAnalytics (14.11.1):
- RNFBAnalytics (15.0.0):
- Firebase/Analytics (= 9.1.0)
- React-Core
- RNFBApp
- RNFBApp (14.11.1):
- RNFBApp (15.0.0):
- Firebase/CoreOnly (= 9.1.0)
- React-Core
- RNFBAppCheck (14.11.1):
- RNFBAppCheck (15.0.0):
- Firebase/AppCheck (= 9.1.0)
- React-Core
- RNFBApp
- RNFBAppDistribution (14.11.1):
- RNFBAppDistribution (15.0.0):
- Firebase/AppDistribution (= 9.1.0)
- React-Core
- RNFBApp
- RNFBAuth (14.11.1):
- RNFBAuth (15.0.0):
- Firebase/Auth (= 9.1.0)
- React-Core
- RNFBApp
- RNFBCrashlytics (14.11.1):
- RNFBCrashlytics (15.0.0):
- Firebase/Crashlytics (= 9.1.0)
- React-Core
- RNFBApp
- RNFBDatabase (14.11.1):
- RNFBDatabase (15.0.0):
- Firebase/Database (= 9.1.0)
- React-Core
- RNFBApp
- RNFBDynamicLinks (14.11.1):
- RNFBDynamicLinks (15.0.0):
- Firebase/DynamicLinks (= 9.1.0)
- GoogleUtilities/AppDelegateSwizzler
- React-Core
- RNFBApp
- RNFBFirestore (14.11.1):
- RNFBFirestore (15.0.0):
- Firebase/Firestore (= 9.1.0)
- React-Core
- RNFBApp
- RNFBFunctions (14.11.1):
- RNFBFunctions (15.0.0):
- Firebase/Functions (= 9.1.0)
- React-Core
- RNFBApp
- RNFBInAppMessaging (14.11.1):
- RNFBInAppMessaging (15.0.0):
- Firebase/InAppMessaging (= 9.1.0)
- React-Core
- RNFBApp
- RNFBInstallations (14.11.1):
- RNFBInstallations (15.0.0):
- Firebase/Installations (= 9.1.0)
- React-Core
- RNFBApp
- RNFBMessaging (14.11.1):
- RNFBMessaging (15.0.0):
- Firebase/Messaging (= 9.1.0)
- React-Core
- RNFBApp
- RNFBML (14.11.1):
- RNFBML (15.0.0):
- React-Core
- RNFBApp
- RNFBPerf (14.11.1):
- RNFBPerf (15.0.0):
- Firebase/Performance (= 9.1.0)
- React-Core
- RNFBApp
- RNFBRemoteConfig (14.11.1):
- RNFBRemoteConfig (15.0.0):
- Firebase/RemoteConfig (= 9.1.0)
- React-Core
- RNFBApp
- RNFBStorage (14.11.1):
- RNFBStorage (15.0.0):
- Firebase/Storage (= 9.1.0)
- React-Core
- RNFBApp
Expand Down Expand Up @@ -1498,23 +1498,23 @@ SPEC CHECKSUMS:
React-RCTVibration: d0361f15ea978958fab7ffb6960f475b5063d83f
React-runtimeexecutor: af1946623656f9c5fd64ca6f36f3863516193446
ReactCommon: 650e33cde4fb7d36781cd3143f5276da0abb2f96
RNFBAnalytics: 33112795bc35a85941c4c94d873836f697fd017f
RNFBApp: d142280345579a35cd150daeb8c20f19580e69ae
RNFBAppCheck: 0e8977e6c416b444c745ac5d2c15f149df4f4b52
RNFBAppDistribution: 35d866cc6388a70e5fc1ddc0520e823e02d1cdf1
RNFBAuth: 625c457d7315947ee8d2e8e839abb5d05a65fa4f
RNFBCrashlytics: 417e27f34e880b162239f50372b2ab069aff78fa
RNFBDatabase: a7930a1c1b3bc36f33dc17b82d9586dc758d0ab9
RNFBDynamicLinks: 1037393032be289db8934c890dce67abcf943831
RNFBFirestore: 2ddac9e2adfb92a7831cf834087bd78f2129cc17
RNFBFunctions: 99bdeb973be84909f1179a699d5a927afdace8d7
RNFBInAppMessaging: 9940daefeb6c832399c22c51677242b1c4710e43
RNFBInstallations: 9b230eabd1472e0cb8ed5f174ab5fc9b5457f7ee
RNFBMessaging: 203ed5691bd14e7e3349ddfabb5f522cec311449
RNFBML: ce312c0b8f8ce31a11badb37e00fb4fe02e54944
RNFBPerf: e4fec5cd0308407b55e68aada3ee0d5090418e49
RNFBRemoteConfig: e0b63b6d5bcf783932e017c6c7c5989a75f91c06
RNFBStorage: 3b98651d8e047a3ef85f55349cc12ea40b64678d
RNFBAnalytics: 8ccd9592707fc23438e79b5afee03b7f8784be93
RNFBApp: 9edb3febb5ef4ca4ef19a9b7c3e78b003b3f5607
RNFBAppCheck: 609f639c8a6ecefafde14f47935fc3803abf91e5
RNFBAppDistribution: 1464c3cd384a8e8c5d4ed17956001f1cd1d0fec4
RNFBAuth: 1bb8b798359adfe67876261804dea5e5edcb4a5c
RNFBCrashlytics: 8cc73044354953e0d75bcd23d550822360e51e87
RNFBDatabase: 8032c2c37e8de1b065bbb8c08b989e67132effbc
RNFBDynamicLinks: 8befdabf134ebfd112e15433d15754c1a6e808da
RNFBFirestore: aa910b8c14c610500077d8110cfb6e05fd400292
RNFBFunctions: a99a0eac7c6101168ca6a3ef011eafd056e191d2
RNFBInAppMessaging: 3ab625bfacbc2baeb846649e61ec7168ed3ccd8b
RNFBInstallations: f4c0c2d313c47bab9b1d47114629f5f7c5794b4c
RNFBMessaging: cb044ac67edf1c696042935e28c84f1a92191b59
RNFBML: 8d5d7a05e1464c9e1a269abfcf7a078b0a8ea181
RNFBPerf: 9da73e85c0a6f2bb8a942193e67d473c28c05418
RNFBRemoteConfig: 566c892b9468cfafdfa4aeb1c63f0958e73129c4
RNFBStorage: dad73f7dcaa242e737e98a3f9c7d481735c97f93
Yoga: 90dcd029e45d8a7c1ff059e8b3c6612ff409061a

PODFILE CHECKSUM: 365a51615bbede8824530bf8d24d06eee48e728e
Expand Down
Loading

1 comment on commit 5da99bd

@vercel
Copy link

@vercel vercel bot commented on 5da99bd Jun 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.