fix(app, android): put app init provider / registrar in correct manifest

local inspection of merged manifest indicated they were not being included as thought, moving them to this manifest shows they are being included
invertase · Aug 15, 2021 · 8408160 · 8408160 · vercel · Aug 15, 2021
1 parent b9670c1
commit 8408160
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 17 deletions.
diff --git a/packages/app/android/src/main/AndroidManifest.xml b/packages/app/android/src/main/AndroidManifest.xml
@@ -1,2 +1,17 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest package="io.invertase.firebase" />
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+  package="io.invertase.firebase">
+
+  <application>
+    <service android:name="com.google.firebase.components.ComponentDiscoveryService">
+      <meta-data
+        android:name="com.google.firebase.components:io.invertase.firebase.app.ReactNativeFirebaseAppRegistrar"
+        android:value="com.google.firebase.components.ComponentRegistrar" />
+    </service>
+    <provider
+      android:name="io.invertase.firebase.app.ReactNativeFirebaseAppInitProvider"
+      android:authorities="${applicationId}.reactnativefirebaseappinitprovider"
+      android:exported="false"
+      android:initOrder="99" /> <!-- Firebase = 100, using 99 to run after Firebase initialises (highest first) -->
+  </application>
+</manifest>
diff --git a/packages/app/android/src/reactnative/AndroidManifest.xml b/packages/app/android/src/reactnative/AndroidManifest.xml
@@ -1,17 +1,2 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-  package="io.invertase.firebase">
-
-  <application>
-    <service android:name="com.google.firebase.components.ComponentDiscoveryService">
-      <meta-data
-        android:name="com.google.firebase.components:io.invertase.firebase.app.ReactNativeFirebaseAppRegistrar"
-        android:value="com.google.firebase.components.ComponentRegistrar" />
-    </service>
-    <provider
-      android:name="io.invertase.firebase.app.ReactNativeFirebaseAppInitProvider"
-      android:authorities="${applicationId}.reactnativefirebaseappinitprovider"
-      android:exported="false"
-      android:initOrder="99" /> <!-- Firebase = 100, using 99 to run after Firebase initialises (highest first) -->
-  </application>
-</manifest>
+<manifest package="io.invertase.firebase" />