Skip to content

Commit

Permalink
fix(android): required compatibility for Gradle 8 in android modules
Browse files Browse the repository at this point in the history
With gratitude to @AndreiCalazans for starting this process of gradle 8
compatibility, there were a few modules that still needed updates to
handle the new default-off BuildConfig setting breaking change from gradle 8

This is required for react-native 0.73 compatibility (currently in RC phase)
as they adopt gradle 8 there
  • Loading branch information
mikehardy committed Oct 21, 2023
1 parent 2d8ac14 commit b52d0ce
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 0 deletions.
6 changes: 6 additions & 0 deletions packages/analytics/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,12 @@ android {
firebaseJsonAutomaticScreenReportingEnabled: automaticScreenReportingEnabled
]
}

buildFeatures {
// AGP 8 no longer builds config by default
buildConfig true
}

lintOptions {
disable 'GradleCompatible'
abortOnError false
Expand Down
6 changes: 6 additions & 0 deletions packages/in-app-messaging/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,12 @@ android {
firebaseJsonAutoInitEnabled: dataCollectionEnabled
]
}

buildFeatures {
// AGP 8 no longer builds config by default
buildConfig true
}

lintOptions {
disable 'GradleCompatible'
abortOnError false
Expand Down
6 changes: 6 additions & 0 deletions packages/messaging/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,12 @@ android {
firebaseJsonNotificationColor: notificationColor
]
}

buildFeatures {
// AGP 8 no longer builds config by default
buildConfig true
}

lintOptions {
disable 'GradleCompatible'
abortOnError false
Expand Down
6 changes: 6 additions & 0 deletions packages/perf/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,12 @@ android {
firebaseJsonCollectionDeactivated: collectionDeactivated
]
}

buildFeatures {
// AGP 8 no longer builds config by default
buildConfig true
}

lintOptions {
disable 'GradleCompatible'
abortOnError false
Expand Down

0 comments on commit b52d0ce

Please sign in to comment.