Skip to content

Commit

Permalink
fix(deps, ios): FirebaseCoreExtension is not always versioned
Browse files Browse the repository at this point in the history
for the 10.23.1 patch release, only a few podspecs were versioned
upstream, and FirebaseCoreExtension was not one of them, it remained
on 10.23.0

If we let that dependency version resolve via semantic specifiers from
FirebaseCore's podspec it will get `~> 10` which is adequate for our purposes
and is in fact how they reference this pod upstream, so the fix is to just
remove the version here and let other specifiers drive the version
  • Loading branch information
mikehardy committed Apr 3, 2024
1 parent 2cee824 commit cb7ed0e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/crashlytics/RNFBCrashlytics.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Pod::Spec.new do |s|

# Firebase dependencies
s.dependency 'Firebase/Crashlytics', firebase_sdk_version
s.dependency 'FirebaseCoreExtension', firebase_sdk_version
s.dependency 'FirebaseCoreExtension'

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/messaging/RNFBMessaging.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Pod::Spec.new do |s|

# Firebase dependencies
s.dependency 'Firebase/Messaging', firebase_sdk_version
s.dependency 'FirebaseCoreExtension', firebase_sdk_version
s.dependency 'FirebaseCoreExtension'

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down

0 comments on commit cb7ed0e

Please sign in to comment.