Skip to content

Commit

Permalink
fix(firestore, ios): remove nanopb transitive dep from podspec
Browse files Browse the repository at this point in the history
Upstream firestore-ios-sdk-frameworks issue is fixed and the Firestore binary distribution now directly depends on nanopb as it should, so we should remove the workaround here.

This tangentially fixes compile of InAppMessaging which was specifying a mutually exclusive nanopb version range
  • Loading branch information
mikehardy committed Sep 17, 2024
1 parent daf2bc9 commit dd657ab
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions packages/firestore/RNFBFirestore.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@ Pod::Spec.new do |s|
# Firebase dependencies
s.dependency 'Firebase/Firestore', firebase_sdk_version

# required until firestore-ios-sdk-frameworks is updated, otherwise users of that distribution will have compile failures
# see https://github.com/invertase/firestore-ios-sdk-frameworks/issues/59
s.dependency 'nanopb', '>= 2.30908.0', '< 2.30910.0'

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
s.static_framework = $RNFirebaseAsStaticFramework
Expand Down

0 comments on commit dd657ab

Please sign in to comment.