Skip to content

Commit

Permalink
fix(auth, android): remove browser dependency, upstream includes now
Browse files Browse the repository at this point in the history
Previous versions of firebase-android-sdk did not express their dependency
on androidx.browser library but used it for reCAPTHCA flow, leading to crashes.
We had to temporarily add a dependency here/downstream to work around.

Upstream has the dependency now, verified via `./gradlew :app:dependencies`

Fixes #4744
  • Loading branch information
mikehardy committed May 19, 2021
1 parent fe3d22f commit e904056
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions packages/auth/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -81,21 +81,10 @@ repositories {
mavenCentral()
}

def safeExtGet(prop, fallback) {
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
}

def BROWSER_VERSION = safeExtGet('androidxBrowserVersion', '[1.0.0, 2.0.0)')

dependencies {
api appProject
implementation platform("com.google.firebase:firebase-bom:${ReactNative.ext.getVersion("firebase", "bom")}")
implementation "com.google.firebase:firebase-auth"

// This is needed for the reCAPTCHA flow but is incorrectly missing as a transitive dependency upstream
// https://github.com/invertase/react-native-firebase/issues/4744
// https://github.com/firebase/firebase-android-sdk/issues/2164
implementation "androidx.browser:browser:${BROWSER_VERSION}"
}

ReactNative.shared.applyPackageVersion()
Expand Down

0 comments on commit e904056

Please sign in to comment.