chore(analytics): PR review updates

invertase · Aug 28, 2020 · fde7651 · fde7651
1 parent 60176c3
commit fde7651
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/packages/analytics/e2e/analytics.e2e.js b/packages/analytics/e2e/analytics.e2e.js
@@ -56,6 +56,16 @@ describe('analytics()', () => {
     });
   });
 
+  describe('setCurrentScreen()', () => {
+    it('screenName only', async () => {
+      await firebase.analytics().setCurrentScreen('invertase screen');
+    });
+
+    it('screenName with screenClassOverride', async () => {
+      await firebase.analytics().setCurrentScreen('invertase screen', 'invertase class override');
+    });
+  });
+
   describe('setMinimumSessionDuration()', () => {
     it('default duration', async () => {
       await firebase.analytics().setMinimumSessionDuration();

diff --git a/packages/analytics/lib/index.js b/packages/analytics/lib/index.js
@@ -103,6 +103,7 @@ class FirebaseAnalyticsModule extends FirebaseModule {
   }
 
   setCurrentScreen(screenName, screenClassOverride) {
+    // eslint-disable-next-line no-console
     console.warn(
       'firebase.analytics().setCurrentScreen(), is now deprecated. Please use firebase.analytics().logScreenView() instead',
     );