Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ml, android): removed unnecessary face models #4753

Merged
merged 1 commit into from
Jan 8, 2021
Merged

fix(ml, android): removed unnecessary face models #4753

merged 1 commit into from
Jan 8, 2021

Conversation

MujtabaFR
Copy link
Contributor

Description

Fixes issue of unnecessary dependencies in @react-native-firebase/ml

Related issues

discussion

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

@vercel
Copy link

vercel bot commented Jan 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/5ibt0y6lf
✅ Preview: https://react-native-firebase-git-fork-mujtabafr-mujtabafr-patch-1.invertase.vercel.app

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #4753 (91d4926) into master (a8dcd54) will increase coverage by 3.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4753      +/-   ##
==========================================
+ Coverage   85.48%   89.09%   +3.61%     
==========================================
  Files         109      109              
  Lines        3712     3712              
  Branches      347      347              
==========================================
+ Hits         3173     3307     +134     
+ Misses        473      363     -110     
+ Partials       66       42      -24     

@mikehardy mikehardy changed the title Removed face detection dependencies fix(ml, android): removed unnecessary face models Jan 8, 2021
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @MujtabaFR - thanks for posting it
I'll issue a 10.4.1 with this fix in just a moment
We're still having some minor issues with publishing I think, so you may see app still at 10.4.0 with every other package at 104.1 but the fix will be in the ml package

@mikehardy mikehardy merged commit a750070 into invertase:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants