Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(firestore): fix typo in FieldValue example #5000

Merged
merged 1 commit into from
Mar 9, 2021
Merged

docs(firestore): fix typo in FieldValue example #5000

merged 1 commit into from
Mar 9, 2021

Conversation

vonovak
Copy link
Contributor

@vonovak vonovak commented Mar 8, 2021

Description

straightforward, thank you

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Mar 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/95FSaqV9LbovLtvEARtFQ5daf9LH
✅ Preview: https://react-native-firebase-git-fork-vonovak-patch-1-invertase.vercel.app

@CLAassistant
Copy link

CLAassistant commented Mar 8, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the perils of code in comments where no compiler checks it :-). Thanks @vonovak

@mikehardy mikehardy changed the title docs: fix typo docs(firestore): fix typo in FieldValue example Mar 8, 2021
@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Mar 8, 2021
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #5000 (54951a4) into master (f3b955c) will decrease coverage by 3.63%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5000      +/-   ##
==========================================
- Coverage   89.09%   85.47%   -3.62%     
==========================================
  Files         109      109              
  Lines        3721     3721              
  Branches      348      348              
==========================================
- Hits         3315     3180     -135     
- Misses        365      476     +111     
- Partials       41       65      +24     

@mikehardy
Copy link
Collaborator

Hey @vonovak - haven't you contributed here before? I really thought you had - but the CLA is reporting it is not signed 🤔 ? https://cla-assistant.io/invertase/react-native-firebase?pullRequest=5000

@vonovak
Copy link
Contributor Author

vonovak commented Mar 8, 2021

@mikehardy I just signed it. I remember I contributed some bit, long time ago. Maybe it was before there was the need to sign anything :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants