-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(firestore): fix typo in FieldValue example #5000
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/95FSaqV9LbovLtvEARtFQ5daf9LH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, the perils of code in comments where no compiler checks it :-). Thanks @vonovak
Codecov Report
@@ Coverage Diff @@
## master #5000 +/- ##
==========================================
- Coverage 89.09% 85.47% -3.62%
==========================================
Files 109 109
Lines 3721 3721
Branches 348 348
==========================================
- Hits 3315 3180 -135
- Misses 365 476 +111
- Partials 41 65 +24 |
Hey @vonovak - haven't you contributed here before? I really thought you had - but the CLA is reporting it is not signed 🤔 ? https://cla-assistant.io/invertase/react-native-firebase?pullRequest=5000 |
@mikehardy I just signed it. I remember I contributed some bit, long time ago. Maybe it was before there was the need to sign anything :) Thanks! |
Description
straightforward, thank you
Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter