Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(analytics, ios): fix on-device-conversion variable name #6331

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

mikehardy
Copy link
Collaborator

Description

Tiny typo fix

Related issues

#6325
#6321
#6264

Release Summary

just a doc change

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Jun 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview Jun 22, 2022 at 3:55PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Jun 22, 2022 at 3:55PM (UTC)

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #6331 (2fa87a6) into main (7affa79) will decrease coverage by 28.66%.
The diff coverage is n/a.

❗ Current head 2fa87a6 differs from pull request most recent head f8b9a3d. Consider uploading reports for the commit f8b9a3d to get more accurate results

@@              Coverage Diff              @@
##               main    #6331       +/-   ##
=============================================
- Coverage     54.50%   25.84%   -28.65%     
=============================================
  Files           208       97      -111     
  Lines         10356     4289     -6067     
  Branches       1645     1048      -597     
=============================================
- Hits           5643     1108     -4535     
+ Misses         4432     2581     -1851     
- Partials        281      600      +319     

@mikehardy mikehardy changed the title doc(analytics, ios): fix on-device-conversion variable name docs(analytics, ios): fix on-device-conversion variable name Jun 22, 2022
@mikehardy mikehardy merged commit 7240128 into main Jun 22, 2022
@mikehardy mikehardy deleted the @mikehardy/on-device-conversion-doc-fix branch June 22, 2022 16:20
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant