Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios, crashlytics): depend on FirebaseCoreExtension #6352

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

mikehardy
Copy link
Collaborator

Description

Crashlytics uses headers from this extension cocoapod, but it is only brought-in
automatically by Storage and Functions currently. Depend on it directly

Related issues

#6322 (comment)

Release Summary

conventional commit

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Hoping for user feedback from @brascene if adding this in the podspec works in place of pulling in functions or storage packages just for this workaround


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Crashlytics uses headers from this extension cocoapod, but it is only brought-in
automatically by Storage and Functions currently. Depend on it directly

#6322 (comment)
@vercel
Copy link

vercel bot commented Jun 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview Jun 28, 2022 at 4:47PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Jun 28, 2022 at 4:47PM (UTC)

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #6352 (07c0ffa) into main (f9a5049) will decrease coverage by 46.48%.
The diff coverage is n/a.

❗ Current head 07c0ffa differs from pull request most recent head 1e07836. Consider uploading reports for the commit 1e07836 to get more accurate results

@@             Coverage Diff             @@
##             main    #6352       +/-   ##
===========================================
- Coverage   72.31%   25.84%   -46.47%     
===========================================
  Files         109       97       -12     
  Lines        4655     4289      -366     
  Branches     1048     1048               
===========================================
- Hits         3366     1108     -2258     
- Misses       1211     2581     +1370     
- Partials       78      600      +522     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant