Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed : duplicate key #7052

Closed
wants to merge 1 commit into from
Closed

removed : duplicate key #7052

wants to merge 1 commit into from

Conversation

imdkbj
Copy link

@imdkbj imdkbj commented Apr 19, 2023

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2023

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Apr 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2023 1:49pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
react-native-firebase-next ⬜️ Ignored (Inspect) Apr 19, 2023 1:49pm

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Thanks for noticing this, it escaped during review
This PR has lots and lots of unrelated changes though and cannot be accepted as is
I've made the same change in a local branch with credit for you in the commit though, and will push that

@mikehardy mikehardy closed this May 10, 2023
mikehardy added a commit that referenced this pull request May 11, 2023
@imdkbj
Copy link
Author

imdkbj commented May 11, 2023

Hi there! Thanks for noticing this, it escaped during review
This PR has lots and lots of unrelated changes though and cannot be accepted as is
I've made the same change in a local branch with credit for you in the commit though, and will push that

Got it, that's due to prettier.

mikehardy added a commit that referenced this pull request May 11, 2023
exaby73 pushed a commit that referenced this pull request Jul 25, 2023
exaby73 pushed a commit that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants