Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app, ios): incorporate firebase-ios-sdk 10.12.0 #7231

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

mikehardy
Copy link
Collaborator

Description

New firebase-ios-sdk / remove remote-config realtime update workarounds

Related issues

All the upstream + here stuff about realtime updates in remoteconfig needing a couple tweaks

Release Summary

Conventional Commits: This Is The Way

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

CI should demonstrate them, the testing was a huge part of the whole process


Think react-native-firebase is great? Please consider supporting the project with any of the below:

with the new firebase-ios-sdk 10.12.0 all the upstream fixes required have
been incorporated + released
@vercel
Copy link

vercel bot commented Jul 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2023 5:50pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
react-native-firebase-next ⬜️ Ignored (Inspect) Jul 12, 2023 5:50pm

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #7231 (464ff02) into main (e52e24e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #7231   +/-   ##
=========================================
  Coverage     53.89%   53.89%           
  Complexity      735      735           
=========================================
  Files           231      231           
  Lines         11607    11607           
  Branches       1863     1863           
=========================================
  Hits           6254     6254           
  Misses         5006     5006           
  Partials        347      347           

@mikehardy mikehardy changed the title feat(app, ios): incorporate firebase-ios-sdk 10.12.0 fix(app, ios): incorporate firebase-ios-sdk 10.12.0 Jul 12, 2023
@mikehardy mikehardy merged commit ee66459 into main Jul 12, 2023
17 checks passed
@mikehardy mikehardy deleted the @mikehardy/ios-sdk-10.12.0 branch July 12, 2023 20:05
exaby73 pushed a commit that referenced this pull request Jul 25, 2023
* fix(app, ios): incorporate firebase-ios-sdk 10.12.0

* fix(remote-config, ios): remove workarounds for realtime updates on iOS

with the new firebase-ios-sdk 10.12.0 all the upstream fixes required have
been incorporated + released
exaby73 pushed a commit that referenced this pull request Aug 8, 2023
* fix(app, ios): incorporate firebase-ios-sdk 10.12.0

* fix(remote-config, ios): remove workarounds for realtime updates on iOS

with the new firebase-ios-sdk 10.12.0 all the upstream fixes required have
been incorporated + released
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant