feat(auth, revokeToken): sign in with apple revokeToken API #7239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
|
mikehardy
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Thanks! Just verified this has been out for a while (firebase-ios-sdk 10.8.0) which shouldn't be a breaking change for anyone since I did a break on the firebase-ios-sdk 10.8.0 release itself
I pushed a commit that fixes up the lint errors, CI should go green with this
mikehardy
changed the title
Codecov Report
@@ Coverage Diff @@
## main #7239 +/- ##
=============================================
- Coverage 69.09% 53.80% -15.29%
- Complexity 0 735 +735
=============================================
Files 129 231 +102
Lines 5363 11628 +6265
Branches 1206 1864 +658
=============================================
+ Hits 3705 6255 +2550
- Misses 1564 5026 +3462
- Partials 94 347 +253 |
|
Releasing this now as should-be 18.3.0 - thanks again! |
|
Sorry, was out of town earlier this week so I couldn't respond. Thanks for fixing up the lint issues and merging! |
|
Thanks folks, it was a pain to do this from the backend. |
exaby73
pushed a commit
that referenced
this pull request
Jul 25, 2023
* feat(revoke): add support for revokeToken API * Fixed there/their * style(auth, lint): result of `yarn lint:android && yarn lint:ios:fix` --------- Co-authored-by: Mike Hardy <github@mikehardy.net>
10 tasks
exaby73
pushed a commit
that referenced
this pull request
Aug 8, 2023
* feat(revoke): add support for revokeToken API * Fixed there/their * style(auth, lint): result of `yarn lint:android && yarn lint:ios:fix` --------- Co-authored-by: Mike Hardy <github@mikehardy.net>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apple requires apps support revocation of the Sign in with Apple token when a user wants to delete their account. Firebase added this support in the Firebase Auth iOS SDK. This PR adds the JS ReactNative bindings so that it can be called from JS.
Related issues
N/A
Release Summary
Added support for revoking a Sign in with Apple token
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
This is the same code that I patched into my own project to revoke Sign in with Apple tokens. I tested it extensively in that app. Unfortunately, I'm not allowed to provide screenshots or videos from that app because it is proprietary.
To make sure this works with your app, it's important to follow the steps outlined here, specifically creating a private key with Apple and filling out the
Services IDandOAuth code flowportions on Firebase correctly.Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter🔥