Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analytics): allow custom event parameters for begin_checkout and purchase events #7760

Merged
merged 2 commits into from
May 3, 2024

Conversation

Minishlink
Copy link
Contributor

@Minishlink Minishlink commented Apr 20, 2024

Description

Hello, Firebase Web SDK allows these extra params: begin_checkout, purchase.
Used the solution from a previous similar PR for screen_view events #5811
This is useful for easily tracking conversion rates depending on some parameters.

Release Summary

Allow custom event parameters for begin_checkout and purchase events

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

  • Tested on Android and iOS, visible in DebugView

Copy link

vercel bot commented Apr 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2024 1:01pm

@mikehardy mikehardy added the Workflow: Needs Review Pending feedback or review from a maintainer. label May 2, 2024
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great - thanks especially for linking the prior PR for an easy comparison and the firebase-js-sdk types for easy reference to make sure we maintain compatibility, all much appreciated

@mikehardy mikehardy changed the title fix(analytics): allow custom event parameters for begin_checkout and purchase events feat(analytics): allow custom event parameters for begin_checkout and purchase events May 2, 2024
@mikehardy mikehardy added Workflow: Pending Merge Waiting on CI or similar and removed Workflow: Needs Review Pending feedback or review from a maintainer. labels May 2, 2024
@mikehardy
Copy link
Collaborator

I don't believe the test failures have anything to do with this PR, I'm struggling with them currently.
One of the Android ones (higher API) went green immediately which is a vote of confidence for the PR.
Low Android API is consistently failing at the moment, it definitely should not block anything.
iOS should have passed but has been flaky. I am re-running it just to see if it goes green, but it won't block merge

@mikehardy
Copy link
Collaborator

@Salakar last one I think - this one also potentially affects typings

@mikehardy mikehardy merged commit 424b9d9 into invertase:main May 3, 2024
18 of 20 checks passed
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants