Light up Parameter Hints for Constructors and Methods #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
changed the title
This bug resulted in member/constructor hints sometimes being applied just before the leftmost open paren.
TheAngryByrd
pushed a commit
that referenced
this pull request
Oct 21, 2023
nojaf
pushed a commit
to nojaf/FsAutoComplete
that referenced
this pull request
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 2ecb8f6
Enhance inlay hints for F# code by adding support for methods and tupled arguments, and improve hint logic. Refactor
InlayHints.fsto avoid duplicate calls.🤖 Generated by Copilot at 2ecb8f6
🚀🛠️♻️
WHY
This lights up type hints for constructor and method parameters! More hints, more better :)
HOW
🤖 Generated by Copilot at 2ecb8f6
ArgumentLocationsproperty ofFSharpParameterLocationInfoand skipping named arguments (link)ShouldCreate.paramHintfunction call to use a local variable and avoid duplication (link)