Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly assign user-provided FSI args and target netstandard when appropriate #504

Merged

Commits on Nov 13, 2019

  1. Fix how we assign FSI options

    For netcore/netfx we should always explicitly provide the targetprofile,
    because the impacts how reference resolution works (ie which primary
    assembly we look for and key off of), and we should also provide any
    static additional arguments as the 'otherFlags' argument.
    
    In addition, we need to explicitly not provide an mscorlib reference
    when targeting netstandard, as that re-enables some of the legacy paths.
    
    Finally, there was a bug in the handling of the 'replace refs' function
    that was overwriting all of the OtherOptions instead of modifying just
    the framework refs.
    baronfel committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    db8baa1 View commit details
    Browse the repository at this point in the history