force roll forward when discovered .NET version is greater than FSAC TFM #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
commented
Jun 30, 2023
src/Core/LanguageService.fs
Outdated
Comment on lines
766
to
768
| let shouldApplyImplicitRollForward = | ||
| not (hasUserFxVersion || hasUserRollForward) | ||
| && sdkTfm <> fsacTfm // if the SDK doesn't match one of our FSAC TFMs, then we're in compat mode |
There was a problem hiding this comment.
core of the change is here - if the derived 'default' TFM of the SDK in use is not the TFM of the version of FSAC that we just chose (e.g. net8.0 on a 8.0.100-preview SDK with a net7.0 TFM FSAC binary), then we must apply rollforward flags to force the runtime to choose 8.0 bits. otherwise on a system with 7.0 bits installed we'll use those.
src/Core/LanguageService.fs
Outdated
Comment on lines
774
to
775
| [ if shouldApplyImplicitRollForward then | ||
| "DOTNET_ROLL_FORWARD", box "LatestMajor" |
There was a problem hiding this comment.
pertinent change 1
src/Core/LanguageService.fs
Outdated
Comment on lines
776
to
780
| match sdkVersion.prerelease with | ||
| | null -> () | ||
| | pres when pres.Count > 0 -> | ||
| "DOTNET_ROLL_FORWARD_TO_PRERELEASE", box "true" | ||
| | _ -> () ] |
There was a problem hiding this comment.
if the sdk in use is a preview we must apply another flag to let the runtime float forward to those previews
TheAngryByrd
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at e108e17
This pull request enhances the compatibility and reliability of the F# language service by improving the fsautocomplete.dll launching logic. It uses the TFMs of the dotnet SDK and the fsautocomplete.dll to determine the best roll-forward policy and arguments. It also refactors and cleans up some code.
🤖 Generated by Copilot at e108e17
🛠️🚀🆕
WHY
When running against a .NET 8 SDK, we can use the net7.0 binaries, but we must roll forward to the more recent Runtime. This is because without this roll forward, if the system has 7.0 runtimes installed the .NET host will prefer using those binaries.
HOW
🤖 Generated by Copilot at e108e17
runtimeVersiontosdkVersionto better reflect its purpose (link)probePathForTFMsto return TFM and path tofsautocomplete.dllfor each TFM (link)fsacPathForTfmwith type signature ofstring * string(link)fsautocomplete.dllpath if it ends with ".dll" (link)discoverDotnetArgsto simplify logic of finding SDK version, FSAC TFM and path, and roll-forward arguments and environment variables (link)fsautocomplete.dllpath inspawnNetCore(link)