Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go module importing #60

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

avorima
Copy link
Contributor

@avorima avorima commented Dec 16, 2019

Go modules with a version higher than 1 require the version in the import path or go get will fail.

@piepmatz
Copy link
Contributor

@pennycoders pennycoders merged commit 13f47bc into ionos-enterprise:master Dec 17, 2019
@pennycoders
Copy link
Contributor

Hi @piepmatz,

Thanks for the PR! Was about to do just this, but was not quite sure how it would impact older golang versions. I have just tested now with 1.11 to 1.13 and it works fine.

Thank you for the PR!

Cheers,

Alex.

@piepmatz
Copy link
Contributor

Forwarding props to @avorima ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants