Add wait for K8s resources #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add_k8s_nodepool_autoscalinglimits_property
* Unused (failed_)supended state removed * AutoScaling node counts must be pointer to uint32, api might return null as value. * Tests added
…toscalinglimits_property
avorima
suggested changes
Sep 2, 2020
go.mod
Outdated
| gopkg.in/check.v1 v1.0.0-20200227125254-8fa46927fb4f // indirect | ||
| gopkg.in/yaml.v3 v3.0.0-20200615113413-eeeca48fe776 // indirect | ||
| k8s.io/apimachinery v0.18.6 |
There was a problem hiding this comment.
No, please don't import apimachinery here. I see you using one function from there, just re-implement it or write an equivalent function.
k8s.go
Outdated
| "k8s.io/apimachinery/pkg/util/wait" | ||
| ) | ||
|
|
||
| type KubernetesClusterNodePoolState string |
k8s.go
Outdated
| K8sStateTerminated KubernetesClusterNodePoolState = "TERMINATED" | ||
| ) | ||
|
|
||
| type KubernetesNodeState string |
k8s.go
Outdated
| func (c *Client) WaitForKubernetesNodePoolState( | ||
| clusterID, nodePoolID string, | ||
| state KubernetesClusterNodePoolState, | ||
| timeout, interval time.Duration) (err error) { |
There was a problem hiding this comment.
The error returned by this function should include which state was polled
k8s.go
Outdated
| clusterID, nodePoolID string, | ||
| state KubernetesClusterNodePoolState, | ||
| timeout, interval time.Duration) (err error) { | ||
| return wait.PollImmediate(interval, timeout, func() (done bool, err error) { |
There was a problem hiding this comment.
These named return values also are not needed
k8s.go
Outdated
| if err != nil { | ||
| return false, err | ||
| } | ||
| return np != nil && np.Metadata != nil && np.Metadata.State == string(state), err |
There was a problem hiding this comment.
Return nil instead of err here
k8s.go
Outdated
| } | ||
|
|
||
| func (c *Client) WaitForKubernetesClusterState( | ||
| clusterID string, state KubernetesClusterNodePoolState, timeout, interval time.Duration) (err error) { |
avorima
suggested changes
Sep 3, 2020
k8s.go
Outdated
| }) | ||
| return np != nil && np.Metadata != nil && np.Metadata.State == state, err | ||
| }); err != nil { | ||
| return fmt.Errorf("error waiting for nodepool state %s [%w]", state, err) |
pennycoders
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bases on: #80