Fix Positioning of Control Header on Google Desktop #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was extended so now it also provides a solution to issue #475. |
iorate
reviewed
Jun 2, 2024
|
I've found some issues in certain result pages:
I'm going to fix it. |
|
Fixed. |
iorate
approved these changes
Jun 6, 2024
|
🎉 This PR is included in version 8.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue reported on #463, where the uBlacklist control header bar (the one that shows how many sites were blocked) would overlap with the Google "Tools" bar.
Demo
control-header-demo.webm
Screencast.from.2024-05-26.22-24-50.webm
Small Note
There is a very small use of the
:has()selector here:ublacklist/src/scripts/search-engines/google-desktop.ts
Lines 158 to 161 in af17cb8
This is a rule that removes a little bit of the margin that was added when there is no blocked entries.
I've tested it on Firefox ESR, and everything is fine.
This is pretty much a case of graceful degradation.