Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/move takeAllowance.sol from wiki #3466

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

vivekjain23
Copy link

Description of change

This is the PR addressing moving Wiki contracts to the wasp repo.
A TakeAllowance.sol contract was added, alongside a solo test for it.

Type of change

fixes issue: #1614

How the change has been tested

A Solo test.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have selected the develop branch as the target branch
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@vivekjain23 vivekjain23 force-pushed the docs/move-TakeAllowance.sol-from-wiki branch from d347d59 to aef8c0b Compare July 11, 2024 13:14
@lucas-tortora
Copy link
Contributor

could you rename the PR to follow the guidelines on confluence?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants