[api] eth_getBlobSidecar #4371
[api] eth_getBlobSidecar #4371
Conversation
|
api/coreservice.go
Outdated
| return res, nil | ||
| } | ||
|
|
||
| func (core *coreService) getBlobSidecars(height uint64) (blobs []any, txIndexes []uint64, txHashes []hash.Hash256) { |
There was a problem hiding this comment.
this func should only return blobs
txIndexes, txHashes should come from core's other API funcs
envestcc
force-pushed
the
eth_getblob
branch
from
2d48f04
to
b907007
Compare
api/coreservice.go
Outdated
| @@ -1213,6 +1217,58 @@ func (core *coreService) getBlockByHeight(height uint64) (*apitypes.BlockWithRec | |||
| }, nil | |||
| } | |||
|
|
|||
| func (core *coreService) BlobSidecarsByHeight(height uint64) ([]*apitypes.BlobSidecarResult, error) { | |||
| header, err := core.bc.BlockHeaderByHeight(height) | |||
api/coreservice.go
Outdated
| txIndices = append(txIndices, uint64(index)) | ||
| } | ||
| blkHash := header.HashBlock() | ||
| for i, blob := range blobs { |
There was a problem hiding this comment.
move L1232 to here, get the index and use it at L1244, then we don't need to define txIndices?
api/coreservice.go
Outdated
| res = append(res, &apitypes.BlobSidecarResult{ | ||
| BlobSidecar: blob, | ||
| BlockNumber: height, | ||
| BlockHash: common.BytesToHash(blkHash[:]), |
There was a problem hiding this comment.
BlockNumber, BlockHash is common for all tx, only need 1 copy, i mean like below?
apitypes.BlobSidecarResult {
BlockNumber
BlockHash
[] struct {
blobSidecar
txIndex
txHash
}
}
There was a problem hiding this comment.
I think we can just keep same as bsc. IMO, this design is to use same structure for getSidercarByBlock and getSidercarByTx
| case nil: | ||
| return res, nil | ||
| case ErrNotFound: | ||
| return nil, nil |
There was a problem hiding this comment.
ErrNotFound should return nil to caller?
There was a problem hiding this comment.
yeah, just like getBlock and getTransaction
| BlockNumber: height, | ||
| BlockHash: common.BytesToHash(blkHash[:]), | ||
| TxIndex: uint64(index), | ||
| TxHash: common.BytesToHash(txHashes[i][:]), |
There was a problem hiding this comment.
do the conversion in line 1230 and save them in local variables.
|
Description
introduce new api
eth_getBlobSidecarsto return blobs in a block.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: