-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gxed Badger hack: use the same net/trace everywhere #94
Conversation
net/trace cannot be imported on different versions from different modules. Additionally, we also cannot export ExpVars with the same names from two different packages (one being gxed-badger and the other being the go-modded one). Since those two packages have different import paths, go considers them different and runs init() twice, causing the issues.
@Stebalien I have isolated this change here so that the migrations PR is cleaner. |
If we use |
That's why I avoided using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The test target will fail if any deps are not vendored. Thus, dropping the check target (which was not used).
576d7f9
to
b368e0a
Compare
@Stebalien you commented while I was vendoring all the things properly. See now? |
So now travis will catch if things not vendored |
net/trace cannot be imported on different versions from different modules.
Additionally, we also cannot export ExpVars with the same names from two different
packages (one being gxed-badger and the other being the go-modded one). Since those
two packages have different import paths, go considers them different and runs
init() twice, causing the issues.