Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gxed Badger hack: use the same net/trace everywhere #94

Merged
merged 4 commits into from
Jan 31, 2020

Conversation

hsanjuan
Copy link
Contributor

net/trace cannot be imported on different versions from different modules.

Additionally, we also cannot export ExpVars with the same names from two different
packages (one being gxed-badger and the other being the go-modded one). Since those
two packages have different import paths, go considers them different and runs
init() twice, causing the issues.

net/trace cannot be imported on different versions from different modules.

Additionally, we also cannot export ExpVars with the same names from two different
packages (one being gxed-badger and the other being the go-modded one). Since those
two packages have different import paths, go considers them different and runs
init() twice, causing the issues.
@hsanjuan hsanjuan self-assigned this Jan 31, 2020
@hsanjuan
Copy link
Contributor Author

@Stebalien I have isolated this change here so that the migrations PR is cleaner.

go.mod Show resolved Hide resolved
@Stebalien
Copy link
Member

If we use go mod vendor, we need to make sure to build with go build -mod=vendor. Although I guess this + go.sum meets the "works if everything else goes down" and "doesn't" change requirements.

@Stebalien
Copy link
Member

That's why I avoided using go mod vendor for all of our other dependencies (e.g., gx, etc.). go build will still fail if the source goes down unless you specify go build -mod=vendor.

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The test target will fail if any deps are not vendored.

Thus, dropping the check target (which was not used).
@hsanjuan
Copy link
Contributor Author

@Stebalien you commented while I was vendoring all the things properly. See now?

@hsanjuan
Copy link
Contributor Author

So now travis will catch if things not vendored

@hsanjuan hsanjuan merged commit 593c0c7 into master Jan 31, 2020
@hsanjuan hsanjuan deleted the fix/badger-deps branch January 31, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants