Remove hardcoded DHT client routing #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
approved these changes
May 23, 2022
There was a problem hiding this comment.
Thank you, LGTM (my rationale in #1859 (comment)).
If a user wants to change the default behavior, they still can do that on Settings screen, by explicitly setting Routing.Type to dhtclient, which is better UX than editing Electron app's internals :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1859
This PR removes the hard-coded dht client mode and instead relies on go-ipfs' defaults which test for the node's dialability and if so switch the DHT to server mode automatically.
A migration was added to remove the hard-coded routing configration from the users config.json.