Network Adapter Refactoring and Tests #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(net:msg) use vendored imports
use a third-party pubsub library for internal communications Insights: * Within bitswap, the actors don't need anything more than simple pubsub behavior. Wrapping and unwrapping messages proves unneccessary. Changes: * Simplifies the interface for both actors calling GetBlock and actors receiving blocks on the network * Leverages a well-tested third-party pubsub library Design Goals: * reduce complexity * extract implementation details (wrapping and unwrapping data, etc) from bitswap and let bitswap focus on composition of core algorithms operations
add interface
added 7 commits
September 17, 2014 20:34
+ test that a partners wants are remembered by message receiver
llSourcell
changed the title
|
Youre gonna kill me with having your branch name different than the one you are requesting a pull from... |
| // NewSender wraps a network Service to perform translation between | ||
| // networkAdapter implements NetworkAdapter | ||
| type networkAdapter struct { | ||
| networkService NetService |
There was a problem hiding this comment.
this naming is inconsistent with the other changes you are making...
|
Im confused about your reasoning for the naming changes |
|
Golint thought that calling a type like Network.networkAdapter is too repetitive, suggested i switch the name so i used net instead of network. |
|
see: https://github.com/jbenet/go-ipfs/tree/master/exchange/bitswap |
ribasushi
pushed a commit
that referenced
this pull request
Jul 4, 2021
Use multiple cores in logger
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Oct 23, 2021
fix: go1.9 monotonic time (for real this time)
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
feat: remove strict signing pubsub option.
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
…ct-signing-option feat: remove strict signing pubsub option.
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Mar 4, 2022
…ct-signing-option feat: remove strict signing pubsub option.
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Mar 4, 2022
…ct-signing-option feat: remove strict signing pubsub option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few confusing naming conventions specifically with network adapter and network service that i clarified.
There was also some circular logic in the network adapter code that needed more clarification.
The NetAdapter interface now contains the HandleMessage method.
Network Adapter needed tests so I went ahead and implemented some tests. 2 of the tests will fail because they depend on a TODO method from Brian, so they are currently commented out.