feat: add Default OpenNIC domain DoH configuration. #9200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds OpenNIC domains (non-ICANN) resolver to default resolvers. Domains added is .bbs .chan .cyb .dyn .geek .gopher .indy .libre .neo .null .o .oss .oz .parody .pirate
matyapiro31
changed the title
lidel
changed the title
lidel
requested changes
Nov 14, 2022
There was a problem hiding this comment.
OpenNIC has been around for over two decades, and the community provides multiple endpoints in the spirit of distributed web.
Supporting OpenNIC TLDs in Kubo will bring support for DNSLinks on these TLDs on public and local gateways, including IPFS Desktop and ipns:// backed by Kubo in Brave (if no custom DoH is selected by the user in Brave Settings).
@matyapiro31 some asks/questions we need to address first:
- DNS.Resolvers (config docs) needs to be updated
- all implicit TLDs from this list need to be listed under
Default.
- all implicit TLDs from this list need to be listed under
- I see this PR is fairly conservative and does not include Peered TLDs
- Was this a conscious decision to limit TLDs to ones directly controlled by OpenNIC (no third-parties) to avoid future problems like suspended peering with
.bitincluding recent.coincontroversy?
- Was this a conscious decision to limit TLDs to ones directly controlled by OpenNIC (no third-parties) to avoid future problems like suspended peering with
- Unsure how future-proof is hard-coding a single DoH endpoint from a smaller service (note that the other ones are from Cloudflare)
- My suggestion is to park this until we can provide a robust solution that won't fail due to a single server being down. This means:
- support for multiple Resolvers per TLD, as noted in Add DNS Fallback Resolvers #8173 (comment) – this will be perfect for OpenNIC, as we could have many resolvers and no single point of failure.
- is this something you would be interesting to submit PR for @matyapiro31? (I am personally willing to allocate review time to land it, as it makes things way more robust)
- (optional) support for DNSCrypt and/or DNS-over-TLS, allowing us to ship defaults with more OpenNIC servers from https://servers.opennic.org/
- support for multiple Resolvers per TLD, as noted in Add DNS Fallback Resolvers #8173 (comment) – this will be perfect for OpenNIC, as we could have many resolvers and no single point of failure.
- My suggestion is to park this until we can provide a robust solution that won't fail due to a single server being down. This means:
lidel
added
help wanted
|
|
@matyapiro31 are you still planning to continue on this PR and #8173, or should we close for now? |
|
I close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds OpenNIC domains (non-ICANN) resolver to default resolvers.
DoH service provider is ethservices, who has been providing DoH service from 2021.
TLDs provided by OpenNIC are: