This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
perf: lazy load format resolvers #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The require time profile for starting an IPFS daemon (`ipfs daemon`) showed IPLD as a significant contributor to the total time spent requiring modules. This is because the formats are all required ahead of time. In total, the default IPLD formats take around 200ms of time to require. This PR adds support for these default modules lazily. You only suffer the require time when you use a particular format. So if you never use git, ethereum or zcash blocks (probably most people right now) they don't contribute to the startup time of your node. License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
- Coverage 88.65% 81.44% -7.22%
==========================================
Files 1 1
Lines 194 194
==========================================
- Hits 172 158 -14
- Misses 22 36 +14
Continue to review full report at Codecov.
|
daviddias
added
status/ready
vmx
approved these changes
Sep 11, 2018
alanshaw
added a commit
to ipfs/js-ipfs
that referenced
this pull request
Nov 9, 2018
This PR uses the new `loadFormat` option for IPLD to lazily require IPLD formats in order to reduce the startup time for the node. If you're feeling like you've seen this before then, for reference: The PR ipld/js-ipld#164 undid the work done in ipld/js-ipld#145 and ipld/js-ipld#178 re-enabled lazy loading. License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
added a commit
to ipfs/js-ipfs
that referenced
this pull request
Nov 12, 2018
This PR uses the new `loadFormat` option for IPLD to lazily require IPLD formats in order to reduce the startup time for the node. If you're feeling like you've seen this before then, for reference: The PR ipld/js-ipld#164 undid the work done in ipld/js-ipld#145 and ipld/js-ipld#178 re-enabled the ability to do so. This PR makes use of this new ability to lazy load the formats. License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The require time profile for starting an IPFS daemon (
ipfs daemon) showed IPLD as a significant contributor to the total time spent requiring modules. This is because the formats are all required ahead of time:In the trace above, you can see the IPLD dependency taking 386ms in total of require time. Of which, the default IPLD formats take around 200ms of time to require. You can see
ipld-bitcoin,ipld-ethereumandipld-zcashtaking the majority of that time.This PR adds support for these default modules lazily. You only suffer the require time when you use a particular format. So if you never use git, ethereum or zcash blocks (probably most people right now) they don't contribute to the startup time of your node.
Now IPLD takes 121ms to require.