Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC syncs ad chains by segment #2464

Merged
merged 1 commit into from
Dec 30, 2023
Merged

GC syncs ad chains by segment #2464

merged 1 commit into from
Dec 30, 2023

Conversation

gammazero
Copy link
Collaborator

Ad chains my be very long, so it is necessary to sync them by segment.

Ad chains my be very long, so it is necessary to sync them by segment.
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2023

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (9b8261a) 46.96% compared to head (6b1a8e5) 46.84%.
Report is 2 commits behind head on main.

Files Patch % Lines
ipni-gc/reaper/reaper.go 18.60% 33 Missing and 2 partials ⚠️
ipni-gc/reaper/option.go 14.28% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2464      +/-   ##
==========================================
- Coverage   46.96%   46.84%   -0.13%     
==========================================
  Files          85       85              
  Lines       10737    10769      +32     
==========================================
+ Hits         5043     5045       +2     
- Misses       5094     5124      +30     
  Partials      600      600              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gammazero gammazero changed the title Sync ad chains by segment GC syncs ad chains by segment Dec 30, 2023
@gammazero gammazero merged commit 8acc51b into main Dec 30, 2023
9 checks passed
@gammazero gammazero deleted the sync-by-segment branch December 30, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants