Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Fix pass declarations #18463

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[NFC] Fix pass declarations #18463

wants to merge 2 commits into from

Conversation

Groverkss
Copy link
Contributor

A number of passes which do not require to be run on FunctionOpInterface are declared to do so. This patch declares them using Pass instead of InterfacePass for Common/Codegen/ Codegen/Common/GPU and Dialects/LinalgExt/ .

This also allows using these passes by using --pass-pipeline in iree-opt.

MaheshRavishankar
MaheshRavishankar requested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@MaheshRavishankar MaheshRavishankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about all of these passes? Some of the allocation related passes might be better to run on function granularity since they change the function itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaheshRavishankar MaheshRavishankar MaheshRavishankar requested changes

@hanhanW hanhanW Awaiting requested review from hanhanW hanhanW is a code owner

@antiagainst antiagainst Awaiting requested review from antiagainst antiagainst is a code owner

@qedawkins qedawkins Awaiting requested review from qedawkins qedawkins is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Groverkss @MaheshRavishankar