Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#204] Policy Cookbook: Add finalize database operation PEP example #277

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

alanking
Copy link
Contributor

Addresses #204

I tried to provide as much context as possible, but maybe it's a bit too much for the cookbook. Happy to rip out stuff.

@korydraughn
Copy link
Collaborator

Nice! Will read through it shortly.

Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done.

docs/administrators/policy_cookbook.md Outdated Show resolved Hide resolved
docs/administrators/policy_cookbook.md Show resolved Hide resolved
docs/administrators/policy_cookbook.md Outdated Show resolved Hide resolved
docs/administrators/policy_cookbook.md Outdated Show resolved Hide resolved
docs/administrators/policy_cookbook.md Outdated Show resolved Hide resolved
docs/administrators/policy_cookbook.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready to me.

Does it work as documented?

@alanking
Copy link
Contributor Author

Yep, the output shown is real (modified to remove timestamps). I don't know how to trigger the *logical_path not being set codepath, so I don't know if that part works, but everything else seems to work.

@korydraughn
Copy link
Collaborator

I think that's fine. I don't actually expect that to ever fail. It's more about presenting concrete examples which demonstrate proper error handling.

Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash and pound it if you're happy with it.

This commit adds a finalize database operation PEP example to the Policy
Cookbook. It also documents how to use the fileModified operation as
an alternative method of achieving similar means.

The example includes usage of the JSON microservices, but it is not
exhaustive.
@alanking
Copy link
Contributor Author

Rebased, squashed, #'d, mergin

@alanking alanking merged commit d785747 into irods:main Aug 26, 2024
1 of 2 checks passed
@alanking alanking deleted the 204.m branch August 26, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants