-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#204] Policy Cookbook: Add finalize database operation PEP example #277
Conversation
Nice! Will read through it shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ready to me.
Does it work as documented?
Yep, the output shown is real (modified to remove timestamps). I don't know how to trigger the |
I think that's fine. I don't actually expect that to ever fail. It's more about presenting concrete examples which demonstrate proper error handling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash and pound it if you're happy with it.
This commit adds a finalize database operation PEP example to the Policy Cookbook. It also documents how to use the fileModified operation as an alternative method of achieving similar means. The example includes usage of the JSON microservices, but it is not exhaustive.
Rebased, squashed, #'d, mergin |
Addresses #204
I tried to provide as much context as possible, but maybe it's a bit too much for the cookbook. Happy to rip out stuff.