Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenQuery2 docs and tweak to syslog docs (main) #278

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

korydraughn
Copy link
Collaborator

No description provided.

@korydraughn korydraughn changed the title GenQuery2 docs and tweak to syslog docs GenQuery2 docs and tweak to syslog docs (main) Aug 26, 2024
@korydraughn
Copy link
Collaborator Author

Forgot to mention logical-or and parens.

Will add words about those soon.

@korydraughn
Copy link
Collaborator Author

I think this is an acceptable start for GenQuery2 documentation.

Feedback welcome.

Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

docs/system_overview/genquery.md Outdated Show resolved Hide resolved
docs/system_overview/genquery.md Show resolved Hide resolved
docs/system_overview/genquery.md Outdated Show resolved Hide resolved
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. Squash when ready (I see you've left a note to self, so will review any additional changes as they come)

@korydraughn
Copy link
Collaborator Author

This is now ready.

Waiting for the signal to squash or tweak.

Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes look good. I like the added distinctions between validation and verification of the SQL. I say squash em.

docs/system_overview/genquery.md Outdated Show resolved Hide resolved
docs/system_overview/genquery.md Outdated Show resolved Hide resolved
docs/system_overview/genquery.md Outdated Show resolved Hide resolved
docs/system_overview/genquery.md Outdated Show resolved Hide resolved
docs/system_overview/genquery.md Show resolved Hide resolved
docs/system_overview/genquery.md Outdated Show resolved Hide resolved
docs/system_overview/genquery.md Outdated Show resolved Hide resolved
docs/system_overview/genquery.md Outdated Show resolved Hide resolved
mkdocs.yml Show resolved Hide resolved
@korydraughn
Copy link
Collaborator Author

See latest commit for changes to GenQuery1 section headers. I modified those so the casing for headers is the same throughout the doc.

@korydraughn
Copy link
Collaborator Author

All review comments have been addressed.

@trel Happy to show a rendering if you're curious about the navigation depth config option. Otherwise, I believe this is ready.

@trel
Copy link
Member

trel commented Aug 27, 2024

yes, let's do that live.

@korydraughn
Copy link
Collaborator Author

Squashed and pounded.

@alanking alanking merged commit 1c9b962 into irods:main Aug 27, 2024
2 checks passed
@korydraughn korydraughn deleted the 264.m branch August 27, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants