Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./min exports files are missing since v10.0.2 #334

Closed
bluwy opened this issue Apr 25, 2024 · 2 comments
Closed

./min exports files are missing since v10.0.2 #334

bluwy opened this issue Apr 25, 2024 · 2 comments

Comments

@bluwy
Copy link

bluwy commented Apr 25, 2024

Since v10.0.2, the ./min exports files are missing. v10.0.1 has the files. GitHub diff between v10.0.1 and v10.0.2.

Personally I'm not using this library nor the specific export, but I found this from https://publint.dev/lru-cache@10.0.2 as lru-cache is a popular npm package.

I think the issue is because fixup.sh is not called before publish. Or package.json tshy.exports doesn't match exports?

@isaacs
Copy link
Owner

isaacs commented Apr 25, 2024

Oh, whoops, I thought fixup.sh was just doing the hybrid stuff, forgot about the minification. Will fix.

@isaacs isaacs closed this as completed in 4a2eca1 Apr 25, 2024
@bluwy
Copy link
Author

bluwy commented Apr 27, 2024

Hey, it seems like it's still not quite fixed yet on v10.2.1 (latest). The .min.js files aren't published: https://www.npmjs.com/package/lru-cache?activeTab=code

https://publint.dev/lru-cache@10.2.1
image

isaacs added a commit that referenced this issue Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants