Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating a hit does not update cache & hit length #41

Closed
jmendiara opened this issue Nov 7, 2014 · 0 comments
Closed

Updating a hit does not update cache & hit length #41

jmendiara opened this issue Nov 7, 2014 · 0 comments

Comments

@jmendiara
Copy link

It only updates their value and now, but the new length calculation and checks for it fits in the cache._max are not performed.

This is not detected when you are using the naiveLength cause it only counts items in the cache.

@isaacs wanna a PR?
jmendiara pushed a commit to jmendiara/serialized-lru-cache that referenced this issue May 4, 2015
Recalculate length on update
a607a32 
fixes isaacs#41
@jmendiara jmendiara mentioned this issue May 4, 2015
Closed
@isaacs isaacs closed this as completed in 46c8e31 Sep 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Recalculate length on update jmendiara/serialized-lru-cache
1 participant
@jmendiara