Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rf flag not working anymore #253

Closed
dhrn opened this issue Jan 21, 2023 · 3 comments
Closed

rf flag not working anymore #253

dhrn opened this issue Jan 21, 2023 · 3 comments

Comments

@dhrn
Copy link

dhrn commented Jan 21, 2023

-rf is not working anymore

image

is that expected? if yes please update in the breaking change

Thanks in advance

@drewjenkins
Copy link

drewjenkins commented Jan 23, 2023

Same with preserveRoot option. I notice the most recent commit is about bad arguments, maybe it broke something?

  rimraf.sync(path.join(path.resolve(__dirname), "my/path"), {
    preserveRoot: true,
  });
Error: invalid rimraf options
    at assertRimrafOptions (.../node_modules/rimraf/src/index.ts:33:11)

@isaacs
Copy link
Owner

isaacs commented Jan 24, 2023

-rf issue fixed on dc2fd42. The bin used to do no argument checking, now it throws if you give it an argument it doesn't understand. (Updated changelog, I'd overlooked this breaking change, sorry.)

@drewjenkins That's a separate issue, and much much more of a head slap.

  typeOrUndef(o.preserveRoot, 'boolean') &&
  typeOrUndef(o.preserveRoot, 'number') &&

yeah.

Fixed on 385f86f

@dhrn
Copy link
Author

dhrn commented Feb 1, 2023

Found the broken usage in the 4.x.x version .

  • rimraf -f
  • rimraf -r

Since this is the major release, ok to have in the breaking change. may be let's update the repo docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants