Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Physical joystick (ONVIF) issues #189

Open
Orvani opened this issue May 10, 2022 · 0 comments
Open

Physical joystick (ONVIF) issues #189

Orvani opened this issue May 10, 2022 · 0 comments

Comments

@Orvani
Copy link
Contributor

Orvani commented May 10, 2022

Stop command not sent when using physical joystick for ONVIF PTZ;
No speed control - constant speed only;
New command not issued if joystick position shift under threshold (threshold is too big);
Orvani added a commit to Orvani/iSpy that referenced this issue May 11, 2022
@Orvani
Fixes for physical joystick (ONVIF)- issue ispysoftware#189
a0c4a3f 
Fixes for physical joystick (ONVIF)-  issue ispysoftware#189

1. Fix bug - pt did not receive a s stop command;
Activate stop command on joystick release; (physical joystick got defined as DigitalPTZ for some reason)
changed internal bool DigitalPTZ => PTZSettings == null;
to
internal bool DigitalPTZ = false;

2. Feature:
Change pan & tilt speed in correlation with joystick position;
used tanh function for more sensitive transformation of joystick position to pan/tilt speed;
@Orvani Orvani mentioned this issue May 11, 2022
Merged
Orvani added a commit to Orvani/iSpy that referenced this issue May 16, 2022
@Orvani
Fixes for pphysical joystick (ONVIF)- issue ispysoftware#189 - update
b86c4ac 
fix bug - physical ptz missing stop command, without break of digital PTZ
internal bool DigitalPTZ => _cameraControl.Camobject.ptz == -1;
ispysoftware added a commit that referenced this issue May 16, 2022
@ispysoftware
Merge pull request #190 from Orvani/master
8e15c3c 
Fixes for physical joystick (ONVIF)-  issue #189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Orvani