Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Feature/js library upgrades #299

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

stoerr
Copy link
Member

@stoerr stoerr commented Mar 1, 2023

The jstree library now and then regularily throws exceptions in the package browser. Upgrading it seems to solve that. I also upgraded loglevel because it has some extensions like enableAll and disableAll. What I'm not clear about is:

  1. Should I leave the old version there or remove it? I could also leave the old one and put the new version as default version into the clientlib.
  2. The jstree proton theme isn't there anymore. I changed to the default theme, which seems to work (although the tree icons are different). But there are some CSS rules .jstree-proton-contextmenu which I don't understand.

One trouble is here that both are used in other composum projects, too, though I haven't seen any negative effects in Pages and Assets when running with Nodes with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant