Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: A test where nyc output help text to stderr was flaky #1269

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

AndrewFinlay
Copy link
Contributor

@AndrewFinlay AndrewFinlay commented Jan 20, 2020

This change allows for flaky output of help information from yargs to stderr when running nyc as a child process.

Fixes #1259.

This change allows for flaky output of help information from `yargs` to `stderr` when running `nyc` as a child process.

More information can be found [here](istanbuljs#1259).
@coreyfarrell coreyfarrell merged commit befbf08 into istanbuljs:master Apr 1, 2020
@coreyfarrell
Copy link
Member

Thanks for the patch! Note I changed the commit prefix from fix: to chore: since we don't want testing fixes to appear in the changelog for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test in nyc's test suite
2 participants