Skip to content

Commit

Permalink
Clarify credentialName usage for separate ca secrets (#2692)
Browse files Browse the repository at this point in the history
Signed-off-by: Faseela K <faseela.k@est.tech>
  • Loading branch information
kfaseela committed Feb 24, 2023
1 parent 181d16c commit 35782d2
Show file tree
Hide file tree
Showing 8 changed files with 13 additions and 3 deletions.
2 changes: 1 addition & 1 deletion mesh/v1alpha1/istio.mesh.v1alpha1.gen.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion networking/v1alpha3/destination_rule.gen.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions networking/v1alpha3/destination_rule.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions networking/v1alpha3/destination_rule.pb.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions networking/v1alpha3/destination_rule.proto
Original file line number Diff line number Diff line change
Expand Up @@ -1099,6 +1099,8 @@ message ClientTLSSettings {
// following keys and values: `key: <privateKey>`,
// `cert: <clientCert>`, `cacert: <CACertificate>`.
// Here CACertificate is used to verify the server certificate.
// For mutual TLS, `cacert: <CACertificate>` can be provided in the
// same secret or a separate secret named `<secret>-cacert`.
// Secret of type tls for client certificates along with
// ca.crt key for CA certificates is also supported.
// Only one of client certificates and CA certificate
Expand Down
2 changes: 1 addition & 1 deletion networking/v1beta1/destination_rule.gen.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions networking/v1beta1/destination_rule.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions networking/v1beta1/destination_rule.proto
Original file line number Diff line number Diff line change
Expand Up @@ -1048,6 +1048,8 @@ message ClientTLSSettings {
// following keys and values: `key: <privateKey>`,
// `cert: <clientCert>`, `cacert: <CACertificate>`.
// Here CACertificate is used to verify the server certificate.
// For mutual TLS, `cacert: <CACertificate>` can be provided in the
// same secret or a separate secret named `<secret>-cacert`.
// Secret of type tls for client certificates along with
// ca.crt key for CA certificates is also supported.
// Only one of client certificates and CA certificate
Expand Down

0 comments on commit 35782d2

Please sign in to comment.