Skip to content

Commit

Permalink
add fallback support for PrivateKeyProvider (#3045)
Browse files Browse the repository at this point in the history
* add fallback support for privatekeyprovider

* add default value into comment

* Update releasenotes/notes/private-key-provider-fallback.yaml

---------

Co-authored-by: Lin Sun <lin.sun@solo.io>
  • Loading branch information
irisdingbj and linsun committed Jan 16, 2024
1 parent 8919509 commit c9b0bf6
Show file tree
Hide file tree
Showing 5 changed files with 105 additions and 24 deletions.
26 changes: 26 additions & 0 deletions mesh/v1alpha1/istio.mesh.v1alpha1.pb.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

79 changes: 55 additions & 24 deletions mesh/v1alpha1/proxy.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions mesh/v1alpha1/proxy.proto
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,10 @@ message PrivateKeyProvider {
// In effect, this value controls the balance between latency and throughput.
// The duration needs to be set to a value greater than or equal to 1 millisecond.
google.protobuf.Duration poll_delay = 1;
// If the private key provider isn’t available (eg. the required hardware capability doesn’t existed)
// Envoy will fallback to the BoringSSL default implementation when the fallback is true.
// The default value is false.
google.protobuf.BoolValue fallback = 2;
}

// QAT (QuickAssist Technology) PrivateKeyProvider configuration
Expand All @@ -321,6 +325,10 @@ message PrivateKeyProvider {
// leading to potentially larger CPU usage.
// The duration needs to be set to a value greater than or equal to 1 millisecond.
google.protobuf.Duration poll_delay = 1;
// If the private key provider isn’t available (eg. the required hardware capability doesn’t existed)
// Envoy will fallback to the BoringSSL default implementation when the fallback is true.
// The default value is false.
google.protobuf.BoolValue fallback = 2;
}

// REQUIRED. Specifies detailed configuration for the Private key provider.
Expand Down
10 changes: 10 additions & 0 deletions proto.lock
Original file line number Diff line number Diff line change
Expand Up @@ -38812,6 +38812,11 @@
"id": 1,
"name": "poll_delay",
"type": "google.protobuf.Duration"
},
{
"id": 2,
"name": "fallback",
"type": "google.protobuf.BoolValue"
}
]
},
Expand All @@ -38822,6 +38827,11 @@
"id": 1,
"name": "poll_delay",
"type": "google.protobuf.Duration"
},
{
"id": 2,
"name": "fallback",
"type": "google.protobuf.BoolValue"
}
]
}
Expand Down
6 changes: 6 additions & 0 deletions releasenotes/notes/private-key-provider-fallback.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
apiVersion: release-notes/v2
kind: feature
area: security
releaseNotes:
- |
**Added** an `fallback` field for PrivateKeyProvider to support fallback to the BoringSSL default implementation if the private key provider isn’t available.

0 comments on commit c9b0bf6

Please sign in to comment.